Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: port upstream clone cookie #1044

Merged
merged 2 commits into from
Jan 5, 2024
Merged

fix: port upstream clone cookie #1044

merged 2 commits into from
Jan 5, 2024

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Jan 4, 2024

πŸ”— Linked issue

Fixes: #1039

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Port upstream to fix the problem.

When a cookie is an object, changing a property within it will change the original referenced object as well, meaning isEqual doesn't detect the change. Instead, we can clone the value straight away so we can detect differences.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx force-pushed the fix/upstream-clone-cookie branch from 19f6e9c to 684e97d Compare January 4, 2024 14:54
@wattanx wattanx force-pushed the fix/upstream-clone-cookie branch from 684e97d to b2fec5b Compare January 4, 2024 15:04
@wattanx wattanx changed the title Fix/upstream clone cookie fix: upstream clone cookie Jan 4, 2024
@wattanx wattanx changed the title fix: upstream clone cookie fix: port upstream clone cookie Jan 4, 2024
@wattanx wattanx marked this pull request as ready for review January 4, 2024 15:06
@wattanx wattanx requested a review from danielroe January 5, 2024 01:59
@danielroe danielroe merged commit 8f1f89e into main Jan 5, 2024
9 checks passed
@danielroe danielroe deleted the fix/upstream-clone-cookie branch January 5, 2024 08:01
@github-actions github-actions bot mentioned this pull request Jan 5, 2024
@github-actions github-actions bot mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to port from upstream
2 participants