Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to Nuxt Eslint #293

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

shinGangan
Copy link
Contributor

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I migrated to Nuxt ESLint and added the following:

  • add eslint-plugin-n (Rules that do not exist in @nuxt/eslint-config but exist in @antfu/eslint-config
  • fix linters error/warning

@shinGangan
Copy link
Contributor Author

Note

The rules set in eslint.config.js are almost the same as those set in the PR below (rules not required for this repo have been omitted).

@shinGangan
Copy link
Contributor Author

Hi @harlan-zw , this PR has low review priority.
Please review when you have a time πŸ™

Thank you for always reviewing :)

@harlan-zw harlan-zw merged commit f6b3105 into nuxt-modules:main Jun 28, 2024
1 check passed
@harlan-zw
Copy link
Collaborator

Amazing, thank you

@shinGangan shinGangan deleted the chore/migrate-nuxt-eslint branch June 28, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants