Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken links #530

Merged
merged 2 commits into from
Oct 7, 2024
Merged

docs: fix broken links #530

merged 2 commits into from
Oct 7, 2024

Conversation

dungsil
Copy link
Contributor

@dungsil dungsil commented Sep 30, 2024

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

fix broken url /headers/xxx -> /documentation/headers/xxx

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 6:56am

@Baroshem
Copy link
Collaborator

Baroshem commented Oct 7, 2024

Hey,

Hmm that is strange because the link works just fine. I just checked it on the documentation. Could you please recheck? Maybe it was fixed somewhere else?

When I click on this link it redirects to https://nuxt-security.vercel.app/documentation/headers/crossoriginembedderpolicy#cross-origin-isolation-issues

@dungsil
Copy link
Contributor Author

dungsil commented Oct 7, 2024

Hello @Baroshem ,
I checked again and I'm still getting a 404 page.

not-found

@Baroshem
Copy link
Collaborator

Baroshem commented Oct 7, 2024

Ahh, I see.

I looked at the wrong place in the same page :D

Merging now!

@Baroshem Baroshem merged commit f7d989c into nuxt-modules:main Oct 7, 2024
3 checks passed
@dungsil dungsil deleted the patch-1 branch October 7, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants