Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): migrate vue-i18n-loader package name #578

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

yoshinorin
Copy link

@yoshinorin yoshinorin commented Jan 27, 2020

Hello. Thank you for awesome package :)

The vue-i18n-loader package name & repo has been changed. Please see the following.

intlify/vue-i18n-loader#69.

This PR update following.

  • dependency
  • docs
  • loader in index.js

@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #578 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #578   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         120    120           
  Branches       31     31           
=====================================
  Hits          120    120
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2263c9d...c758c83. Read the comment docs.

@rchl
Copy link
Collaborator

rchl commented Feb 17, 2020

Thank you for this PR.
Unfortunately, this needs to be a major change since some might have configured vue-i18n-loader using those options https://nuxt-community.github.io/nuxt-i18n/vue-i18n-loader.html#yaml
So I'm gonna merge this when I feel like it's a good time to release a new major version.

@yoshinorin
Copy link
Author

yoshinorin commented Feb 18, 2020

@rchl
Thank you for your review :)
OK. Please let me know when you merge this, I will rebase this PR to master before you merge :)

@rchl
Copy link
Collaborator

rchl commented Feb 18, 2020

Actually I was thinking we should handle migration automatically. From the extendBuild hook we can check config.module.rules and modify instances of @kazupon/vue-i18n-loader with @intlify/vue-i18n-loader. We just have to remember that loader can be either a string or array. Then we can release it as minor change.

Would you be able to do that?

@yoshinorin
Copy link
Author

OK. I will try it out this weekend :)

@rchl
Copy link
Collaborator

rchl commented Feb 23, 2020

I've looked into it.

I don't think we need migration for it as documentation example was outdated and using it that way would have not worked anyway. vue-i18n-loader has had support for yaml for a while now and it's supposed to be used with lang="yaml" attribute now.

I've updated documentation and added a test for yaml block in 2385665. You can cherry pick that commit (it's in main repo) and then I'll merge it.

@yoshinorin yoshinorin force-pushed the update_vue-i18n-loader branch from 2385665 to c758c83 Compare February 25, 2020 15:13
@yoshinorin
Copy link
Author

Sorry, so the late reply.
I cherry-pick 2385665 and force-pushed from the current master branch.

@rchl rchl merged commit 1c30949 into nuxt-modules:master Feb 25, 2020
@rchl
Copy link
Collaborator

rchl commented Feb 25, 2020

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants