Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default language multi domain locales #3250

Conversation

DotwoodMedia
Copy link
Contributor

πŸ”— Linked issue

Some routes are missing for default language when using multiDomainLocales and prefix_except_default #3248

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

πŸ—’οΈ Note

Developed by: Social Deal (@socialdeal)

DotwoodMedia and others added 3 commits November 29, 2024 09:18
…stments

Developed by: Social Deal (@socialdeal)

Co-authored-by: Vincent de Vreede <vincentdevreede@live.nl>
Developed by: Social Deal (@socialdeal)

Co-authored-by: Dotwood Media <info@dotwood.media>
@DotwoodMedia DotwoodMedia changed the title Bugfix/default language multi domain locales fix: default language multi domain locales Nov 29, 2024
@BobbieGoede
Copy link
Collaborator

Thanks for contributing!

Could you add a test to assert the desired behavior (and also to prevent regressions with further changes) πŸ™?

@DotwoodMedia
Copy link
Contributor Author

@BobbieGoede I just added a new test for the behavior of the child routes πŸ˜„

Copy link
Collaborator

@BobbieGoede BobbieGoede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BobbieGoede BobbieGoede merged commit 7f7eaf2 into nuxt-modules:main Dec 3, 2024
8 checks passed
@e-kravtsov
Copy link

Guys, you are lightning fast, thank you!

@DotwoodMedia DotwoodMedia deleted the bugfix/default-language-multi-domain-locales branch December 3, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some routes are missing for default language when using multiDomainLocales and prefix_except_default
4 participants