-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: runtime config support for detectBrowserLanguage
#2824
Merged
kazupon
merged 13 commits into
nuxt-modules:main
from
BobbieGoede:feature/runtime-config-detect-browser-language-4
Mar 2, 2024
Merged
feat: runtime config support for detectBrowserLanguage
#2824
kazupon
merged 13 commits into
nuxt-modules:main
from
BobbieGoede:feature/runtime-config-detect-browser-language-4
Mar 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
BobbieGoede
changed the title
feat: runtime config detect browser language
feat: runtime config Mar 1, 2024
detectBrowserLanguage
BobbieGoede
changed the title
feat: runtime config
feat: runtime config support for Mar 1, 2024
detectBrowserLanguage
detectBrowserLanguage
kazupon
approved these changes
Mar 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! π
LGTM for your PR!
You need to resolve the conflicts!
BobbieGoede
force-pushed
the
feature/runtime-config-detect-browser-language-4
branch
from
March 2, 2024 08:56
ef097a2
to
8283c8c
Compare
7 tasks
DarthGigi
pushed a commit
to DarthGigi/i18n
that referenced
this pull request
Apr 16, 2024
β¦s#2824) * feat: add runtime config support for detectBrowserLanguage * chore(deps): update dependencies * test: add test helper to set runtime config * test: merge browser language detection tests * test: merge baseUrl tests * chore(deps): update dependencies * refactor: cleanup * chore(deps): update dependencies * chore(deps): update dependencies * fix: add type exceptions * chore(deps): update dependencies * fix: composable usage and passing * chore(deps): update nuxt dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Requires feat: allow oveeridng nested runtime config with envΒ nitrojs/nitro#1831 to be mergedAnd anitropack
release including this change to be updated innuxt
These have been merged and released
Primary motivation for adding runtime support is to actually to merge more test files π. Most if not all code for
detectBrowserLanguage
is used at runtime, so there is no need to rebuild the project to test each options.nitrojs/nitro#1831 allows us to override runtime configs objects with environment variables, as this is currently not possible.
This PR changes the
@nuxt/test-utils
code further,startServer
now optionally accepts additional environment variables. And I added helper functions to make setting runtime config variables via environment variables easier.Using the following in a test
Will be converted into
NUXT_PUBLIC_I18N_DETECT_BROWSER_LANGUAGE=false
and restarts the server with all properties in the passed object.π Checklist