Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support variable default export for defineI18nConfig #2792

Merged
merged 2 commits into from
Feb 15, 2024
Merged

fix: support variable default export for defineI18nConfig #2792

merged 2 commits into from
Feb 15, 2024

Conversation

BobbieGoede
Copy link
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves #2094

Not sure if this is the correct way to do this, I have no experience working with ASTs.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede requested a review from kazupon February 15, 2024 09:58
kazupon
kazupon approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@kazupon kazupon merged commit cf8cd25 into nuxt-modules:main Feb 15, 2024
7 checks passed
DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
@BobbieGoede
fix: support variable default export for defineI18nConfig (nuxt-modul…
1cbf88a 
…es#2792)

* fix: support variable default export for `defineI18nConfig`

* test: add variable export `defineI18nConfig` test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support variable identifier default export for defineI18nConfig
2 participants
@BobbieGoede @kazupon