fix(meta): add missing router.base prefix to favicon
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The favicon must be accessible from any page and it does not matter how deep the page is. The only possible solution is to use a relative url.
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
=======================================
Coverage 85.43% 85.43%
=======================================
Files 10 10
Lines 357 357
Branches 108 108
=======================================
Hits 305 305
Misses 48 48
Partials 4 4
Continue to review full report at Codecov.
|
pi0
reviewed
Oct 1, 2020
lib/meta/module.js
Outdated
| @@ -111,7 +111,7 @@ function generateMeta (pwa) { | |||
| if (options.favicon && !find(this.options.head.link, 'rel', 'shortcut icon') && existsSync(favicon)) { | |||
| console.warn('You are using a low quality icon, use icon png. See https://pwa.nuxtjs.org/icon/') | |||
|
|
|||
| this.options.head.link.push({ rel: 'shortcut icon', href: 'favicon.ico' }) | |||
| this.options.head.link.push({ rel: 'shortcut icon', href: '/favicon.ico' }) | |||
pi0
changed the title
pi0
changed the title
router.base prefix to favicon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The favicon must be accessible from any page and it does not matter how deep the page is. The only possible solution is to use a relative url.