Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull empty IDs instead of filling them with upsert #2656

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Pull empty IDs instead of filling them with upsert #2656

merged 2 commits into from
Jan 17, 2025

Conversation

spawnia
Copy link
Collaborator

@spawnia spawnia commented Jan 17, 2025 •
edited
Loading

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

This avoids passing empty IDs (0, '' or null) along and filling them into the model.

Breaking changes

I hope not.

@spawnia spawnia added the bug An error within Lighthouse label Jan 17, 2025
@spawnia spawnia merged commit f6b46c1 into master Jan 17, 2025
41 checks passed
@spawnia spawnia deleted the upsert-pull-empty-id branch January 17, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug An error within Lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@spawnia