Federation v2 @shareable types
#2485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
requested changes
Dec 11, 2023
…ouse into federation-shareable-types
|
Thank you, released with https://github.com/nuwave/lighthouse/releases/tag/v6.28.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR marks shared types (types that can be shared by multiple services) with the
@shareabledirective when federation v2 is enabled.Right now I've updated the pagination types. @spawnia do you think there are other types that makes sense to mark as
@shareable?Breaking changes
None.
When using federation v2, types declared in multiple services must be marked as
@shareableso right now you must override this types in order to use federation v2