Skip to content

Pattern::isFieldVisible returns false on valid mappings by using field instead of id #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 8.x-1.x
Choose a base branch
from
Open

Pattern::isFieldVisible returns false on valid mappings by using field instead of id #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17edf70
use field id for visibility check
Dec 21, 2021
d06e18a
Remove patch
Dec 21, 2021
8f2e0c6
Add support for additional fields on PatternDefinitionField
May 19, 2022
431e5cd
Remove support for additional fields on PatternDefinitionField
May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/ui_patterns_views/src/Plugin/views/row/Pattern.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,11 @@ public function submitOptionsForm(&$form, FormStateInterface $form_state) {
*
* @see template_preprocess_pattern_views_row()
*/
public function isFieldVisible(FieldPluginBase $field, $field_output) {
public function isFieldVisible(FieldPluginBase $field, $field_name, $field_output) {
$empty_value = $field->isValueEmpty($field_output, $field->options['empty_zero']);
$hide_field = !$empty_value || (empty($field->options['hide_empty']) && empty($this->options['hide_empty']));
$empty = empty($field->options['exclude']) && $hide_field;
return $empty && $this->hasMappingDestination('views_row', $field->field, $this->options);
return $empty && $this->hasMappingDestination('views_row', $field_name, $this->options);
}

}
2 changes: 1 addition & 1 deletion modules/ui_patterns_views/ui_patterns_views.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function template_preprocess_pattern_views_row(array &$variables) {
$field_name = $mapping['source'];
$field = $view->field[$field_name];
$field_output = $view->style_plugin->getField($row->index, $field_name);
if ($row_plugin->isFieldVisible($field, $field_output)) {
if ($row_plugin->isFieldVisible($field, $field_name, $field_output)) {
$destination = $row_plugin->getMappingDestination('views_row', $field_name, $options);
$fields[$destination][] = $field_output;
}
Expand Down