Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Enable building binary only on macos #918

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

jimmidyson
Copy link
Member

Current config only allows building local binaries on Linux machines so
adding config to allow building binaries on macos without changing the
release config (and hence still only releasing linux binaries as required).

@dkoshkin
Copy link
Contributor

I'm not sure I understand what this PR is doing, when would be want to build a MacOS binary, isn't it always used inside a container?

@jimmidyson
Copy link
Member Author

Yes it does always run in a container, but I found it useful to have the binary locally to check flags when I was adding feature gates.

At the same time, if you run make build-snapshot on macos without this pr then literally nothing builds, not the binary, not the image, nada. This pr fixes that as well so a native darwin binary will be built plus the Linux container with relevant arch.

Current config only allows building local binaries on Linux machines so
adding config to allow building binaries on macos without changing the
release config (and hence still only releasing linux binaries as required).
@jimmidyson jimmidyson force-pushed the jimmi/build-snapshot-macos branch from b6960a9 to 2dd052f Compare October 2, 2024 08:39
@jimmidyson jimmidyson requested a review from mhrabovcin October 2, 2024 08:41
@jimmidyson jimmidyson enabled auto-merge (squash) October 2, 2024 08:56
@jimmidyson jimmidyson merged commit a4ef700 into main Oct 2, 2024
20 checks passed
@jimmidyson jimmidyson deleted the jimmi/build-snapshot-macos branch October 2, 2024 09:09
@dkoshkin dkoshkin mentioned this pull request Oct 15, 2024
jimmidyson pushed a commit that referenced this pull request Oct 15, 2024
🤖 I have created a release *beep* *boop*
---


## 0.18.0 (2024-10-15)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Add feature-gates plumbing by @jimmidyson in
#919
* feat(api): Add kubernetes version to coredns version mapping by
@thunderboltsid in
#939
### Fixes 🔧
* fix: Shorten readiness probe period to try to prevent races by
@jimmidyson in
#930
* fix: Rename webhook container to manager by @jimmidyson in
#932
* fix: list correct registry.k8s.io/sig-storage/csi-snapshotter image by
@dkoshkin in
#943
* fix: include kube-vip image in generated caren-images.txt by @dkoshkin
in
#940
### Other Changes
* test(e2e): Add v1.30.5 test for Nutanix by @thunderboltsid in
#931
* build: Enable building binary only on macos by @jimmidyson in
#918
* build(deps): Update clusterctl binary to v1.8.3 by @thunderboltsid in
#929


**Full Changelog**:
v0.17.0...v0.18.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants