refactor: Rename GenericClusterConfig to GenericSpec #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlipovetsky
force-pushed
the
rename-genericclusterconfig
branch
from
1c62aa7
to
813c698
Compare
dlipovetsky
changed the title
jimmidyson
reviewed
Mar 18, 2024
This reduces stuttering, and aligns better with the names of the similar types AWSSpec and DockerSpec. This is not an API change, because the struct is inlined, and the name is not part of the API.
dlipovetsky
force-pushed
the
rename-genericclusterconfig
branch
from
813c698
to
bd83e7c
Compare
|
I think we can close this now that #537 is merged? |
|
Agreed @dkoshkin - @dlipovetsky if you disagree and would still like to do this rename, please rebase and reopen this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces stuttering, and aligns better with the names of the similar types AWSSpec and DockerSpec.
This is not an API change, because the struct is inlined, and the name is not part of the API.