Remove v1alpha4 CRDs, types and associated code #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thunderboltsid
changed the title
thunderboltsid
force-pushed
the
issue/remove-v1alpha4
branch
from
3d2b6f7 to
52fe69a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
- Coverage 31.74% 31.69% -0.05%
==========================================
Files 14 14
Lines 1367 1366 -1
==========================================
- Hits 434 433 -1
Misses 933 933 ☔ View full report in Codecov by Sentry. |
|
/retest |
thunderboltsid
force-pushed
the
issue/remove-v1alpha4
branch
from
52fe69a to
f3403cd
Compare
|
/retest |
|
@thunderboltsid: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/hold putting on hold until GitHub Actions are fixed |
thunderboltsid
force-pushed
the
issue/remove-v1alpha4
branch
from
f3403cd to
6703a1c
Compare
adiantum
approved these changes
Jul 8, 2024
thunderboltsid
force-pushed
the
issue/remove-v1alpha4
branch
from
6703a1c to
f8dca6c
Compare
Remove all supporting test code for v1alpha4
thunderboltsid
force-pushed
the
issue/remove-v1alpha4
branch
from
f8dca6c to
1b6fee9
Compare
dkoshkin
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1alpha4 has been deprecated and unserved in the past releases. This removes v1alpha4 and all supporting test code for v1alpha4. We are not aware of anyone using v1alpha4 APIs.