Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Nutanix CCM cipher-suites to fix sweet32 CVE #439

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

tuxtof
Copy link
Contributor

@tuxtof tuxtof commented May 29, 2024

What this PR does / why we need it:

Enforce specific tls-cipher-suite to fix Nutanix CCM SWEET32 CVE

Release note:

- Fix Nutanix CCM Sweet32 issue

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.62%. Comparing base (dc98d5e) to head (5908af1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   30.62%   30.62%           
=======================================
  Files          14       14           
  Lines        1342     1342           
=======================================
  Hits          411      411           
  Misses        931      931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thunderboltsid
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

@deepakm-ntnx deepakm-ntnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for completeness, could you please document where did this list come from? and in future how should one keep it up to date.
also how is this tested?

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakm-ntnx, thunderboltsid, tuxtof

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [deepakm-ntnx,thunderboltsid,tuxtof]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuxtof tuxtof force-pushed the fix/ccm-sweet32 branch from 368e118 to 5908af1 Compare May 31, 2024 09:03
@tuxtof
Copy link
Contributor Author

tuxtof commented May 31, 2024

just for completeness, could you please document where did this list come from? and in future how should one keep it up to date. also how is this tested?

I just align with the settings coming from the other components
who are coming from field best practice . compared with other k8s distro

@thunderboltsid
Copy link
Contributor

/retest

@tuxtof tuxtof merged commit e03f712 into main May 31, 2024
6 of 7 checks passed
@tuxtof tuxtof deleted the fix/ccm-sweet32 branch May 31, 2024 14:53
tuxtof added a commit that referenced this pull request May 31, 2024
Co-authored-by: Christophe Jauffret <christophe.jauffret@nutanix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants