Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick PR #416 to release-v1.3 #432

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

thunderboltsid
Copy link
Contributor

Cherry-Pick Details

  • Original PR Title: Explicitly set a exponential backoff rate limiter for controller config
  • Original PR URL: Explicitly set a rate limiter for controller config #416
  • Commit SHA: 714c151
  • Cherry-Pick Reason: Cherry-picking changes related to rate limiter to release-v1.3 so when a user upgrades from 1.2.5 to 1.3.4, they don't fall back to basic auth

@thunderboltsid thunderboltsid changed the title Cherry-pick PR #416 to release-v1.2 Cherry-pick PR #416 to release-v1.3 May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 69.69697% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 16.58%. Comparing base (814f505) to head (a4bb472).

Files Patch % Lines
main.go 64.28% 10 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-v1.3     #432      +/-   ##
================================================
+ Coverage         15.49%   16.58%   +1.08%     
================================================
  Files                21       21              
  Lines              2098     2129      +31     
================================================
+ Hits                325      353      +28     
- Misses             1773     1776       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adiantum,thunderboltsid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…ig (#416)

The rate limiter base delay and max delay values can be configured using
flags. The default values are 500ms for base delay and 15min for max delay.
Copy link

✅ None of your dependencies violate policy!

@thunderboltsid
Copy link
Contributor Author

/retest

@thunderboltsid thunderboltsid merged commit 68a6d8a into release-v1.3 May 14, 2024
11 of 13 checks passed
@thunderboltsid thunderboltsid deleted the jira/krbn-8105 branch May 14, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants