Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick PR #398 to release-v1.3 #431

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

thunderboltsid
Copy link
Contributor

Cherry-Pick Details

This will ensure we make fewer basic auth requests to Prism Central
IAM Services.
Copy link

✅ None of your dependencies violate policy!

@thunderboltsid
Copy link
Contributor Author

/test e2e-k8s-conformance

@thunderboltsid thunderboltsid changed the title Cherry-pick PR #398 to release-v1.2 Cherry-pick PR #398 to release-v1.3 May 10, 2024
@thunderboltsid
Copy link
Contributor Author

/test e2e-k8s-upgrade

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 15.49%. Comparing base (98239ba) to head (33e1b0d).

Files Patch % Lines
pkg/client/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-v1.3     #431      +/-   ##
================================================
+ Coverage         15.44%   15.49%   +0.04%     
================================================
  Files                21       21              
  Lines              2104     2098       -6     
================================================
  Hits                325      325              
+ Misses             1779     1773       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adiantum,thunderboltsid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thunderboltsid thunderboltsid merged commit 814f505 into release-v1.3 May 14, 2024
11 of 13 checks passed
@thunderboltsid thunderboltsid deleted the jira/krbn-8096 branch May 14, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants