Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed namespace for clusterclass and cluster with topology #384

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

deepakm-ntnx
Copy link
Contributor

@deepakm-ntnx deepakm-ntnx commented Mar 6, 2024

What this PR does / why we need it:
This PR removes the default addition of namespace in all the objects related to clusterclass and cluster with topology so that user does not have to define an extra env variable NAMESPACE and can provide teh same at the time of kubectl create/apply itself giving them flexibility and its also a standard practice in the industry

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

How Has This Been Tested?:

make cluster-templates
make cluster-e2e-templates

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@nutanix-cn-prow-bot
Copy link

nutanix-cn-prow-bot bot commented Mar 6, 2024

@deepakm-ntnx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-k8s-upgrade a0648b2 link false /test e2e-k8s-upgrade
ci/prow/e2e-capx-conformance a0648b2 link false /test e2e-capx-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deepakm-ntnx
Copy link
Contributor Author

/retest-required

@deepakm-ntnx
Copy link
Contributor Author

/test e2e-capx-controller-upgrade

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.37%. Comparing base (aec5951) to head (a0648b2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   20.37%   20.37%           
=======================================
  Files          17       17           
  Lines        1212     1212           
=======================================
  Hits          247      247           
  Misses        965      965           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thunderboltsid
Copy link
Contributor

/lgtm
/approve

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepakm-ntnx, jimmidyson, thunderboltsid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [deepakm-ntnx,thunderboltsid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thunderboltsid thunderboltsid merged commit 55e8e38 into nutanix-cloud-native:main Mar 7, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants