removed enable-hostpath-provisioner entry #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reason: it was carry forward from docker provider and is not needed for nutanix provider kcp and kcpt
deepakm-ntnx
requested review from
tuxtof,
jimmidyson,
adiantum,
thunderboltsid and
yannickstruyf3
|
local testing results with quick-start test make test-e2e-calico LABEL_FILTERS=quickstart Output When following the Cluster API quick-start Should create a workload cluster [quickstart, capx-feature-test] /Users/deepak.muley/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.3.5/e2e/quick_start.go:78 STEP: Creating a namespace for hosting the "quick-start" test spec @ 01/19/24 15:29:10.682 INFO: Creating namespace quick-start-rudnef INFO: Creating event watcher for namespace "quick-start-rudnef" STEP: Creating a workload cluster @ 01/19/24 15:29:10.709 INFO: Creating the workload cluster with name "quick-start-z5lu20" using the "(default)" template (Kubernetes v1.27.9, 1 control-plane machines, 1 worker machines) INFO: Getting the cluster template yaml INFO: clusterctl config cluster quick-start-z5lu20 --infrastructure (default) --kubernetes-version v1.27.9 --control-plane-machine-count 1 --worker-machine-count 1 --flavor (default) INFO: Applying the cluster template yaml to the cluster configmap/quick-start-z5lu20-pc-trusted-ca-bundle created configmap/nutanix-ccm created configmap/cni-quick-start-z5lu20-crs-cni created secret/quick-start-z5lu20 created secret/nutanix-ccm-secret created clusterresourceset.addons.cluster.x-k8s.io/nutanix-ccm-crs created clusterresourceset.addons.cluster.x-k8s.io/quick-start-z5lu20-crs-cni created kubeadmconfigtemplate.bootstrap.cluster.x-k8s.io/quick-start-z5lu20-kcfg-0 created cluster.cluster.x-k8s.io/quick-start-z5lu20 created machinedeployment.cluster.x-k8s.io/quick-start-z5lu20-wmd created machinehealthcheck.cluster.x-k8s.io/quick-start-z5lu20-mhc created kubeadmcontrolplane.controlplane.cluster.x-k8s.io/quick-start-z5lu20-kcp created nutanixcluster.infrastructure.cluster.x-k8s.io/quick-start-z5lu20 created nutanixmachinetemplate.infrastructure.cluster.x-k8s.io/quick-start-z5lu20-mt-0 created INFO: Waiting for the cluster infrastructure to be provisioned STEP: Waiting for cluster to enter the provisioned phase @ 01/19/24 15:29:13.31 INFO: Waiting for control plane to be initialized INFO: Waiting for the first control plane machine managed by quick-start-rudnef/quick-start-z5lu20-kcp to be provisioned STEP: Waiting for one control plane node to exist @ 01/19/24 15:29:23.348 INFO: Waiting for control plane to be ready INFO: Waiting for control plane quick-start-rudnef/quick-start-z5lu20-kcp to be ready (implies underlying nodes to be ready as well) STEP: Waiting for the control plane to be ready @ 01/19/24 15:30:23.432 STEP: Checking all the control plane machines are in the expected failure domains @ 01/19/24 15:30:23.44 INFO: Waiting for the machine deployments to be provisioned STEP: Waiting for the workload nodes to exist @ 01/19/24 15:30:23.471 STEP: Checking all the machines controlled by quick-start-z5lu20-wmd are in the "" failure domain @ 01/19/24 15:30:53.519 INFO: Waiting for the machine pools to be provisioned STEP: PASSED! @ 01/19/24 15:30:53.566 |
|
/retest |
test/e2e/data/infrastructure-nutanix/v1.2.4/base/cluster-with-kcp.yaml
Outdated
Show resolved
Hide resolved
test/e2e/data/infrastructure-nutanix/v1.3.0/base/cluster-with-kcp.yaml
Outdated
Show resolved
Hide resolved
thunderboltsid
requested changes
Jan 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
=======================================
Coverage 15.21% 15.21%
=======================================
Files 18 18
Lines 1209 1209
=======================================
Hits 184 184
Misses 1025 1025 ☔ View full report in Codecov by Sentry. |
thunderboltsid
approved these changes
Jan 22, 2024
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adiantum, deepakm-ntnx, thunderboltsid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reason: it was carry forward from docker provider and is not needed for nutanix provider kcp and kcpt
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
How Has This Been Tested?:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and test output
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: