Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codecov.yml to omit generated code #361

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

thunderboltsid
Copy link
Contributor

Everytime we add or modify a CRD, we will fail to meet generated code coverage. The onus of ensuring the correctness of generated code lies on the generator itself. We can, in future, think about generating tests for this code (trust but verify) but, for the time being, it's best to exclude this from metrics.

Everytime we add or modify a CRD, we will fail to meet generated
code coverage. The onus of ensuring the correctness of generated
code lies on the generator itself. We can, in future, think about
generating tests for this code (trust but verify) but, for the time
being, it's best to exclude this from metrics.
@nutanix-cn-prow-bot
Copy link

@thunderboltsid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-capx-controller-upgrade 3fc7abe link false /test e2e-capx-controller-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@adiantum adiantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@nutanix-cn-prow-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adiantum, thunderboltsid, tuxtof, yannickstruyf3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adiantum,thunderboltsid,tuxtof,yannickstruyf3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thunderboltsid thunderboltsid merged commit ba2b194 into main Jan 15, 2024
3 of 10 checks passed
@nutanix-cn-prow-bot nutanix-cn-prow-bot bot deleted the omit-gen-files branch January 15, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants