Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Real minor fixes #713

Merged
merged 5 commits into from
Jan 14, 2018
Merged

Real minor fixes #713

merged 5 commits into from
Jan 14, 2018

Conversation

taneliang
Copy link
Member

@taneliang taneliang commented Jan 14, 2018 •
edited
Loading

"Minor fixes"

  1. Add key prop to global search sem badges.
  2. Fix the warning "You tried to return focus to but it is not in the DOM anymore".
    1. Upstream issue: 'You tried to return focus to but it is not in the DOM anymore' warning. reactjs/react-modal#577.
    2. TL;DR: A fix was released in react-modal 3.1.8.
  3. Fix Poor scrolling performance of search results in Safari on macOS #679 using this SO answer

@mods-bot
Copy link

mods-bot commented Jan 14, 2018 •
edited
Loading

Deploy preview for nusmods ready!

Built with commit fb759a3

https://deploy-preview-713--nusmods.netlify.com

li-kai
li-kai approved these changes Jan 14, 2018
View reviewed changes
Copy link
Member

@li-kai li-kai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐟

@taneliang taneliang merged commit 8433840 into master Jan 14, 2018
@taneliang taneliang deleted the real-minor-fixes branch January 14, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-kai li-kai li-kai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poor scrolling performance of search results in Safari on macOS
3 participants
@taneliang @mods-bot @li-kai