Fix run-p script glob on yarn 2+
#3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@SuibianP is attempting to deploy a commit to a Personal Account owned by @nusmodifications on Vercel. @nusmodifications first needs to authorize it. |
Yarn 2+ expands glob patterns using its own shell and fails the `lint` script. Quote the pattern to prevent premature expansion. Escaped double quotes are used for compatibility with cmd.exe. Related-Bug: mysticatea/npm-run-all#200 yarnpkg/berry#1814
SuibianP
force-pushed
the
yarn-new-glob-quote
branch
from
dd957ba to
768794c
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #3611 +/- ##
=======================================
Coverage 53.44% 53.44%
=======================================
Files 271 271
Lines 5862 5862
Branches 1396 1396
=======================================
Hits 3133 3133
Misses 2729 2729 ☔ View full report in Codecov by Sentry. |
zwliew
approved these changes
Aug 20, 2023
|
Thank you! I haven't looked into yarn 2 yet but I'm open to the idea of upgrading to it. Someone just has to do it :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Yarn 2+ expands glob patterns using its own shell and fails the
lintscript.No issue created due to its trivial nature.
Implementation
Quote the pattern to prevent premature expansion. Escaped double quotes are used for compatibility with
cmd.exe.Other Information
Related-Bug: mysticatea/npm-run-all#200 yarnpkg/berry#1814
Does the project officially support/plan to migrate to yarn 2+? If so, would it be better if such configuration is added to the test matrix?