suggestion: added style #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personally, I'd love to see "style" added. You can't get colorful enough for me. |
|
@rsteube |
i assume, rsteube is the owner of carapace and this pull request comes from a carapace issue relating nushell. |
Yes, An additional attribute in the results similar to the config should work: https://github.com/nushell/nushell/blob/main/crates/nu-cli/src/reedline_config.rs#L162 let style = match text {
Value::String { val, .. } => lookup_ansi_color_style(&val),
Value::Record { .. } => color_record_to_nustyle(&text),
_ => None
}; |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
==========================================
+ Coverage 47.59% 49.28% +1.68%
==========================================
Files 47 46 -1
Lines 9312 8009 -1303
==========================================
- Hits 4432 3947 -485
+ Misses 4880 4062 -818
|
rsteube
force-pushed
the
suggestion-style
branch
4 times, most recently
from
7cfac29
to
c2bf6c5
Compare
|
You can test this with nushell/nushell#11442 and the current master branch of carapace-bin: cd cmd/carapace
go generate ./...
go install |
|
@rsteube I now have carapace installed and we are ready continue working on this PR.... The CI is reporting one failing check having to do with the spelling of "wheres" which should be "whereas" Also you will probably need to update your code somewhat as the branch has conflicts... Thank you ! |
supports reverse highlighting using nu.config
```nushell
style: {
text: white
selected_text: {
attr: r
}
description_text: white_dimmed
}
```
|
I think you just need to merge main because we added wheres a while back Line 13 in 7d08fc8 |
rsteube
force-pushed
the
suggestion-style
branch
from
949bf1f
to
27bf852
Compare
|
@rsteube thanks for getting this going so quickly today and being very patient for a long time... Glad we were finally able to land this PR --- sorry it took so long 😄 |
fdncred
pushed a commit
to nushell/nushell
that referenced
this pull request
Jan 25, 2024
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description Adds style support. Reverse highlighting is recommended for the [completion-menu](https://www.nushell.sh/book/line_editor.html#completion-menu): ```nushell style: { text: white selected_text: { attr: r } description_text: white_dimmed } ``` needs nushell/reedline#691 related #5292 fix carapace-sh/carapace#967 <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> # User-Facing Changes Style support for values during completion:   <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
stormasm
pushed a commit
that referenced
this pull request
Jan 26, 2024
* get correct cursor pos when menu indicator contains newline * add tests * fix cursor pos in multiline prompt * make description mode enum public * add doc comment * respect windows newline in update_values * Revert "respect windows newline in update_values" This reverts commit 070d600. * add complete_with_base_ranges to Completer * add builder for correct_cursor_pos * add config options to completion examples * add style to ide menu * run fmt * start menu refactor * Revert "start menu refactor" This reverts commit 62726f2.
Merged
dmatos2012
pushed a commit
to dmatos2012/nushell
that referenced
this pull request
Feb 20, 2024
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description Adds style support. Reverse highlighting is recommended for the [completion-menu](https://www.nushell.sh/book/line_editor.html#completion-menu): ```nushell style: { text: white selected_text: { attr: r } description_text: white_dimmed } ``` needs nushell/reedline#691 related nushell#5292 fix carapace-sh/carapace#967 <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> # User-Facing Changes Style support for values during completion:   <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverse highlighting with config "record" for reverse:
related nushell/nushell#5292
related carapace-sh/carapace#546