Skip to content

fix(frontend): origin address info leak #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(frontend): origin address info leak #2709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/device-image/DeviceImage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export function DeviceImage(props: Readonly<DeviceImageProps>) {

if (type === 'svg') {
return (
<Suspense fallback={<image crossOrigin={'anonymous'} {...rest} href={genericDevice} />}>
<Suspense fallback={<image {...rest} href={genericDevice} />}>
<ErrorBoundary>
<LazyImage type="svg" device={device} {...rest} />
</ErrorBoundary>
Expand Down
4 changes: 2 additions & 2 deletions src/components/device-image/LazyImage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function LazyImage(props: Readonly<LazyImageProps>) {
srcList: AVAILABLE_GENERATORS.map((fn) => fn(device)).filter(Boolean) as string[],
});
if (type === 'svg') {
return <image crossOrigin={'anonymous'} {...rest} href={src} />;
return <image {...rest} href={src} />;
}
return <img alt="" crossOrigin={'anonymous'} src={src} />;
return <img alt="" src={src} />;
}
2 changes: 0 additions & 2 deletions src/components/settings-page/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ const rows = [
<div className="col">
<a target="_blank" rel="noopener noreferrer" href="https://www.buymeacoffee.com/nurikk">
<img
crossOrigin="anonymous"
src="https://img.buymeacoffee.com/button-api/?text=Thanks for frontend&emoji=🍺&slug=nurikk&button_colour=FFDD00&font_colour=000000&font_family=Arial&outline_colour=000000&coffee_colour=ffffff"
/>
</a>
Expand All @@ -75,7 +74,6 @@ const rows = [
<div className="col">
<a target="_blank" rel="noopener noreferrer" href="https://www.buymeacoffee.com/koenkk">
<img
crossOrigin="anonymous"
src="https://img.buymeacoffee.com/button-api/?text=Thanks for zigbee2mqtt&emoji=☕&slug=koenkk&button_colour=FFDD00&font_colour=000000&font_family=Arial&outline_colour=000000&coffee_colour=ffffff"
/>
</a>
Expand Down
1 change: 1 addition & 0 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<meta name="robots" content="noindex">
<meta name="referrer" content="no-referrer">

<title>Zigbee2MQTT</title>

Expand Down