Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DeviceControlGroup): add interview button #2027

Merged
merged 2 commits into from
May 31, 2024

Conversation

justfalter
Copy link
Contributor

* Adds an "interview" button which starts an interview for the
  associated device. See Koenkk/zigbee2mqtt#22788
* The icon is [fa-info](https://fontawesome.com/v6/icons/info?f=classic&s=solid).
@LaurentChardin
Copy link
Contributor

@justfalter You just need to run prettier on your files to align the formatting.

@Koenkk
Copy link
Collaborator

Koenkk commented May 30, 2024

@justfalter please run npm run pretty as @LaurentChardin indicated, then this is ready for merge.

@justfalter
Copy link
Contributor Author

@LaurentChardin @Koenkk all prettied up!

@Koenkk Koenkk merged commit 452fc00 into nurikk:dev May 31, 2024
2 of 3 checks passed
@Koenkk
Copy link
Collaborator

Koenkk commented May 31, 2024

Many thanks!

Koenkk added a commit to Koenkk/zigbee2mqtt that referenced this pull request Jun 1, 2024
@Great-Chart
Copy link

Apologies if this isn't the best place to add this (minor) point; but it seems a logical place to include it.

I had one problem device that I'd need to re-pair occasionally and it would fail and interview and I can confirm this has resolved that (long standing issue)! But when attempting this on a mobile device it's very hard to be sure that I'd actually clicked on Interview and not Reconfigure (the former icon being narrow thus the target box itself if narrower than most (worse on mobile).
image

As the dialogue box appears largely a duplicate of that for the Reconfigure option its worth noting that neither pop-ups actually define themselves as Reconfigure of Interview (Whereas those for Rename and Delete do include this).
With the Reconfigure and (new) Interview icons so close and them presenting identical pop-up dialogue boxes both named as Confirmation Prompt its not obvious which you are acknowledging!
image
But some appropriate text would (likely) make all the difference.
image

It would thus be useful if all such pop-up dialogue boxes adopted this additional clarity.

ghoz pushed a commit to ghoz/zigbee2mqtt that referenced this pull request Jun 14, 2024
@NickVulkers
Copy link

Apologies if this isn't the best place to add this (minor) point; but it seems a logical place to include it.

I had one problem device that I'd need to re-pair occasionally and it would fail and interview and I can confirm this has resolved that (long standing issue)! But when attempting this on a mobile device it's very hard to be sure that I'd actually clicked on Interview and not Reconfigure (the former icon being narrow thus the target box itself if narrower than most (worse on mobile). image

As the dialogue box appears largely a duplicate of that for the Reconfigure option its worth noting that neither pop-ups actually define themselves as Reconfigure of Interview (Whereas those for Rename and Delete do include this). With the Reconfigure and (new) Interview icons so close and them presenting identical pop-up dialogue boxes both named as Confirmation Prompt its not obvious which you are acknowledging! image But some appropriate text would (likely) make all the difference. image

It would thus be useful if all such pop-up dialogue boxes adopted this additional clarity.

+1, I've had to do this a few times recently and the target box sizing quickly became my enemy. Clarifying your requested action in the confirmation prompt is already a good step, even better would be reworking the buttons for mobile devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants