Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge upstream 2024 08 28 t1757 0500 #5

Merged
merged 10 commits into from
Aug 28, 2024

Conversation

fidiego
Copy link
Contributor

@fidiego fidiego commented Aug 28, 2024

No description provided.

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
demo-installer ✅ Ready (Inspect) Visit Preview Aug 28, 2024 11:00pm

fidiego added 10 commits August 28, 2024 17:58
…l_markdown (#46)

* fix: update install inputs

* feat: interpolate install.install_inputs.values into the post_install_markdown

* feat: hijack enter for stepper navigation

the stepper is wrapped in one big form element so pressing enter in any
of the steps would submit the form. this is less than intutitive
behavior since users are likely to interpret the sections of the stepper
as distinct forms.

as a result, we opt to hijack/intercept enters on the form and use it to
navigate the stepper instead of submitting the form. now, the only way
to submit the form is via the (re)provision button.

* feat: interpolate install.id into the post install markdown
* theme example: dark card updates

* app: use display name, if available
* feat: mov cloud configs after the app configs

* feat: add card drop shadows back and in theme
* theme: update default button shadow

* logo: ensure largest logos render
* feat: ignore .env files

* feat: delegation aware installer

only works for ios. is backwards compatible.
the last step is special in the sense that its state depends on the
state of the Stepper/Steps AND on the state of the Install. in this
commit, we introduce a method for dynamically determining the last
Step's activeClassName to achieve the desired state-based border
color.
* chore: npm audit fix

* feat: allow installer to pull the installerId from searchParams

this required a refactor of the root layout and modifications to the way
we handle `Metadata`.

- [ ] figure out how to use `searchParams` in the `generateMetadata`
- [ ] ensure the metadata is generated well regardless of what method we
      use to get the installerId.

* feat: include metadata in all pages
@fidiego fidiego force-pushed the fd/merge-upstream-2024-08-28T1757-0500 branch from cf3683b to c4c94a9 Compare August 28, 2024 22:59
@fidiego fidiego merged commit d33df0a into main Aug 28, 2024
4 checks passed
@fidiego fidiego deleted the fd/merge-upstream-2024-08-28T1757-0500 branch August 28, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant