Fd/merge upstream branch 2024 08 28 t1504 0500 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l_markdown (#46) * fix: update install inputs * feat: interpolate install.install_inputs.values into the post_install_markdown * feat: hijack enter for stepper navigation the stepper is wrapped in one big form element so pressing enter in any of the steps would submit the form. this is less than intutitive behavior since users are likely to interpret the sections of the stepper as distinct forms. as a result, we opt to hijack/intercept enters on the form and use it to navigate the stepper instead of submitting the form. now, the only way to submit the form is via the (re)provision button. * feat: interpolate install.id into the post install markdown
* theme example: dark card updates * app: use display name, if available
* theme: update default button shadow * logo: ensure largest logos render
* feat: ignore .env files * feat: delegation aware installer only works for ios. is backwards compatible.
this required a refactor of the root layout and modifications to the way
we handle `Metadata`.
- [ ] figure out how to use `searchParams` in the `generateMetadata`
- [ ] ensure the metadata is generated well regardless of what method we
use to get the installerId.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test of nuonco/installer#59