feat: merge upstream 2024 08 20 t1646 0500 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l_markdown (#46) * fix: update install inputs * feat: interpolate install.install_inputs.values into the post_install_markdown * feat: hijack enter for stepper navigation the stepper is wrapped in one big form element so pressing enter in any of the steps would submit the form. this is less than intutitive behavior since users are likely to interpret the sections of the stepper as distinct forms. as a result, we opt to hijack/intercept enters on the form and use it to navigate the stepper instead of submitting the form. now, the only way to submit the form is via the (re)provision button. * feat: interpolate install.id into the post install markdown
With the recent changes to render input values in the form, it looks like the installer could no longer handle installs with no inputs. This change should fix that.
* theme example: dark card updates * app: use display name, if available
if it is present
* feat: mov cloud configs after the app configs * feat: add card drop shadows back and in theme
* theme: update default button shadow * logo: ensure largest logos render
* feat: ignore .env files * feat: delegation aware installer only works for ios. is backwards compatible.
the last step is special in the sense that its state depends on the state of the Stepper/Steps AND on the state of the Install. in this commit, we introduce a method for dynamically determining the last Step's activeClassName to achieve the desired state-based border color.
…ream-2024-08-20T1646-0500
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fidiego
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge latest from https://github.com/nuonco/installer