Labels: Add OnOutputOnly option, and deprecate On/All #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewimcclement
added a commit
to andrewimcclement/nunitdocs
that referenced
this pull request
Sep 1, 2023
Note On and All as deprecated. See nunit/nunit-console#721 and nunit/nunit-console#630 for relevant changes.
SeanKilleen
pushed a commit
to nunit/docs
that referenced
this pull request
Sep 2, 2023
Note On and All as deprecated. See nunit/nunit-console#721 and nunit/nunit-console#630 for relevant changes.
github-actions bot
pushed a commit
to nunit/docs
that referenced
this pull request
Sep 2, 2023
Note On and All as deprecated. See nunit/nunit-console#721 and nunit/nunit-console#630 for relevant changes. 9919fa4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #636, the changes as discussed in #630.
This adds
OnOutputOnlyas a more explicit name forOn, and deprecates bothOnandAll- which has been a duplicate ofBeforefor a few releases now. Deprecation is done in the same way as the existing deprecated--paramsoption.The reasoning for this was to reduce ambiguity in the API. The original options were just
OnandOff. As new options have been added since version 3.0,OnandAllhave become ambiguous in meaning.Oncurrently represents the most limited option of label output available (only displaying labels for test output, andAlldisplays less labels than the newBeforeAndAfteroption. The deprecation message explains which alternative to switch to in each case, and looks like the below.Not the only affect of this is an additional line in the console output - it does not change the exit code of the console, or the TestResults xml.
The old labels are converted to their new terms at the very top level of the console, and all lower functionality and tests removed, to make for easier removal in future. New tests have been added to cover the conversion, while the deprecated options remain. 🙂