Ensure that all subpackages are located correctly #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There appears to be an issue with AppVeyor regarding loading certain NuGet packages. Not sure what we can do about that. |
|
The problem with nuget is the same as in #515 which should be solved by #525, but it seems like the solution is not enough. I'll see if I have time to look at it tonight. Edit: And AppVeyor had new images uploaded 11 February (see e.g. AppVeyor Windows images update. There was no changes to msbuild, but nuget was bumped. |
| var packages = new List<TestPackage>(TestPackage.SubPackages); | ||
| if (packages.Count == 0) | ||
| packages.Add(TestPackage); | ||
|
|
ChrisMaddock
approved these changes
Mar 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #546
This fix ensures that all leaf packages - those without subpackages - are handled in DirectRunner no matter how deep the hierarchy of packages and subpackages is.
It continues to pass all tests and solves the problem of not being able to run a project file using the --process:Separate option. However, I have not added a test for that case since it would require a project loader extension to be installed in order to function. This seems to be another one to deal with in the accepttance tests.
I intended to make a similar change in AggregatingTestRunner but discovered that the comparable code there for examining packages was not being used and removed it.