Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .Net 8.0 #1320

Merged
merged 3 commits into from
Feb 20, 2023
Merged

Add support for .Net 8.0 #1320

merged 3 commits into from
Feb 20, 2023

Conversation

OsirisTerje
Copy link
Member

  • Updated to not crash when .net 8 is installed
  • Updated building information

Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the runner doesn't seem to really do anything with this, is it possible to cherry pick my commit to main from 11 months ago where the dependency was removed completely?

See:
Author: Manfred Brands manfred-brands@users.noreply.github.com
Date: 11 months ago (31/03/2022 12:15:58)
Commit hash: d5648b9
Child: 100b434
Parent: 0d5ea36

Removed ClrVersion from RuntimeFramework

Decision logic moved to Runtime class.

@OsirisTerje
Copy link
Member Author

OsirisTerje commented Feb 20, 2023

@manfred-brands I wasn't really aware of this, @CharliePoole made some comments about it, but I didn't know it had been done. Will do this.

UPDATE:
When doing this I do get quite a bunch of merge conflicts. AgentProcess.cs, RuntimeFrameworkservices.cs I accepted all from incoming. Not sure if this is all ok. I don't have proper control over this.

SORRY: This didn't work out. Too many merges, and ended with 43 compiler errors, and I have no clue what I am actually changing here.

It is not possible to cherry-pick only that commit. The class/file Runtime.cs was created March 1st, #a5b701c , and there are others in between which seem to be involved.

@rprouse rprouse added this to the 3.16.3 milestone Feb 20, 2023
@rprouse rprouse merged commit 95fb00f into version3 Feb 20, 2023
@rprouse rprouse deleted the net8 branch February 20, 2023 21:30
@rprouse rprouse added the Bug label Feb 21, 2023
@rprouse rprouse changed the title Net8 Add support for .Net 8.0 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants