Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when targeting .NET Framework with .NET 7 installed #1175

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

YuhanKun
Copy link

Related to:
#1176
#1014

@dnfadmin
Copy link

dnfadmin commented Mar 19, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Only 6 months after I added the line for 6.

@CharliePoole
Copy link
Collaborator

I see no problem with this so I'm merging. The Linux and MacOS failures in azure are a separate problem.

Note that this change does not enable you to run tests targeting .NET 7.0. As with net 6.0, that requires more work.

@YuhanKun Thanks for your contribution.

@manfred-brands Welcome! I see you accepted my invitation. It's a bit annoying that GitHub doesn't notify me when someone accepts. Please contact me by email so we can talk about your participation (charliepoole AT gmail DOT com)

@CharliePoole
Copy link
Collaborator

Sorry... I indicated I was merging this four days ago but I appear not to have done so. Merging now!

@ankushjain358
Copy link

.Net 7 is released today and nunit is working fine. It's tested using NUnit3TestAdapter v4.3.0

@CharliePoole
Copy link
Collaborator

@ankushjain358 True but not relevant here. This is about testing with the console runner, not the test adapter. :-)

However, console runner version 3.16.0-dev00073 does support testing under today's release of .NET 7.0. The full release of 3.16 will be out next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants