Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mock-assembly using nunit framework version 4.0.0 #1150

Conversation

manfred-brands
Copy link
Member

@manfred-brands manfred-brands commented Feb 19, 2022

Fixes #1139

Added mock-nunit4-assembly based upon mock-assembly-x86
Added mock-nunit4 tests to package-tests.cake

nunit4 support net45, netcoreapp3.1 and net5.0/net6.0

I dropped net5.0/net6.0:
Testing net5.0 package with nunit-console netcore3.1 runner failed.
net6.0 is outside the VS2017 scope.

@CharliePoole
Copy link
Collaborator

@manfred-brands It looks as if you based this on an old copy of dev-4.0 rather than main. We've been working on 4.0 in main for a few months so you're missing a number of changes. The dev-4.0 branch is still there in case it's needed for comparison, but maybe I should delete it to avoid confusion.

Can you re-apply your changes on top of main? (You will probably need to make changes in the scripts)

@manfred-brands
Copy link
Member Author

Replaced by #1156

@manfred-brands manfred-brands deleted the dev-4.0-issue1139-add-nunit4-tests branch February 22, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants