Let PackageDefinition build the package itself #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been resolved in version 3.13.1 The release is available on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring change in support of #1057.
My last bit of script refactoring was much too big, so I'm just doing little pieces now. The advantage is they are easier to review. The disadvantage is it may not be obvious why I'm making a particular change.
In this case, I'm eliminating a bunch of procedural code and allowing the package definition class to do the building through an abstract method, which is overridden for each of the four package types: NuGet, Chocolatey, Msi and Zip. This works together with the representation of all our packages in package-definition.cake and will eventually lead to the packages publishing themselves as well.