Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically roll-forward if no .NET Core 3.1 runtime available #1012

Closed
k15tfu opened this issue Sep 4, 2021 · 5 comments · Fixed by #1093
Closed

Automatically roll-forward if no .NET Core 3.1 runtime available #1012

k15tfu opened this issue Sep 4, 2021 · 5 comments · Fixed by #1093
Assignees
Labels
Bug NetCoreRunner Issue related to the .NET Core console runner
Milestone

Comments

@k15tfu
Copy link
Contributor

k15tfu commented Sep 4, 2021

Hi!

What do you think about adding RollForward Major policy in nunit3-console.csproj to allow it to run on .NET 5 without additional options? Currently I can run it without any problem using .NET Core 3.1 runtime, but on .NET 5 it fails with:

$ .../dotnet-runtime-5.0.9-linux-x64/dotnet exec .../nunit.consolerunner.netcore.3.12.0-beta2/tools/netcoreapp3.1/any/nunit3-console.dll
It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '3.1.0' was not found.
  - The following frameworks were found:
      5.0.9 at [.../dotnet-runtime-5.0.9-linux-x64/shared/Microsoft.NETCore.App]

You can resolve the problem by installing the specified framework and/or SDK.

The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=3.1.0&arch=x64&rid=ubuntu.18.04-x64

And I need to use --fx-version 5.0.9 or --roll-forward Major options to get it to run successfully. It will also help switching to .NET 6 after release. I can make a PR for this.

Linked issues: #858, #932

cc @ChrisMaddock

@CharliePoole
Copy link
Member

@k15tfu I'd like to get this as well as some other bugs fixed for the next release. Your PR would be welcome. Make sure the change is conditioned on the netcoreapp3.1 target. Thanks!

@CharliePoole CharliePoole added pri:normal NetCoreRunner Issue related to the .NET Core console runner and removed Needs Confirmation labels Jan 1, 2022
@CharliePoole
Copy link
Member

@k15tfu Were you doing a PR for this? I'd like to get it into the 3.14 release

@k15tfu
Copy link
Contributor Author

k15tfu commented Jan 15, 2022

@CharliePoole Yes, review please #1093.

@CharliePoole
Copy link
Member

@k15tfu Thanks! I merged it. We can talk about your other changes after the release.

@CharliePoole
Copy link
Member

This issue has been resolved in version 3.14.0

The release is available on:
GitHub.
NuGet packages are also available NuGet.org and
Chocolatey Packages may be found at Chocolatey.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug NetCoreRunner Issue related to the .NET Core console runner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants