Skip to content

Commit

Permalink
Fix for the adapter issues 1065 and 1066
Browse files Browse the repository at this point in the history
  • Loading branch information
OsirisTerje committed Feb 27, 2023
1 parent e868668 commit 92b88e9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion GitVersion.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
next-version: 3.14.0
next-version: 3.15.3

This comment has been minimized.

Copy link
@CharliePoole

CharliePoole Feb 27, 2023

Collaborator

Don't you mean 3.16.3?

This comment has been minimized.

Copy link
@OsirisTerje

This comment has been minimized.

Copy link
@OsirisTerje

OsirisTerje Feb 28, 2023

Author Member

If I understand it right, the Microsoft package was needed for that, and was introduced the same time. Interesting is this: nunit/nunit3-vs-adapter#1066 (comment)

This comment has been minimized.

Copy link
@OsirisTerje

OsirisTerje Feb 28, 2023

Author Member

Sorry @CharliePoole , I am writing on too many things now. The comments above is for the issue I raised, assumed wrongly you commented on that.

For the version number change, I actually MEAN 3.15.3 because the version is based on the 3.15.2 release, not the 3.16.3 release which was done last week. The 3.15.3 will let the 3.15 version work with .net 8, and thus "fix" the issue referred to, but it will be a downgrade.

mode: ContinuousDelivery
legacy-semver-padding: 5
build-metadata-padding: 5
Expand Down
5 changes: 4 additions & 1 deletion src/NUnitEngine/nunit.engine.core/RuntimeFramework.cs
Original file line number Diff line number Diff line change
Expand Up @@ -203,8 +203,11 @@ private Version GetClrVersionForFramework(Version frameworkVersion)
return new Version(6, 0, 0);
case 7:
return new Version(7, 0, 0);
case 8:
return new Version(8, 0, 0);
default:
return new Version(frameworkVersion.Major, 0, 0);
}
break;
}

throw new ArgumentException("Unknown framework version " + frameworkVersion.ToString(), "version");
Expand Down

0 comments on commit 92b88e9

Please sign in to comment.