-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option 'update' #7
Conversation
ping @Ecco... |
Well, is this really needed? It seems like this is a bit bloated… I mean, if you want to do I don't think we need to bother doing this at the setup-msys2 level. |
The main purpose is to do something actually useful instead of |
Well, we could as well do… nothing 😄 The point of
Well, I thought about this and didn't do it for two reasons:
|
I might change it from |
Well, my opinion is that it's better to not introduce extra config options for things which can easily be done on a case-by-case basis. And I think it's easy to just add a line which says But if you think it's really useful for a lot of users, then I'm ok with merging it as-is, though. Don't bother with a half-assed "init" alternative 😄 |
My use case is that I want to have both options: test building the stable version of a tool with the stable MSYS2 distribution (to generate release artifacts); and test the I'd like to avoid adding one or two explicit (conditional) steps for that, because I consider it to be part of the environment setup, not of the workflow (build, test, deploy). Since it is actually 4 lines of code, I think it is not much effort to maintain it (although 15 lines of tests are added). |
Fair enough 😄 |
Currently,
uname -a
is executed by default after extracting MSYS2. The purpose of executing it is to initialize the environment, so it is not delayed until the user calls the first command.This PR adds option/parameter
update
, which will replaceuname -a
withpacman -Syu --noconfirm
. On the one hand, this makes the initialization call actually useful, instead of being "dummy". On the other hand, updating the environment allows to use packages which were published after the tarball was released/cached.Corresponding tests are added to the GHA worklow, and the README is updated.