Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Fix CIs for sphinx 6 #448

Merged
merged 1 commit into from
Jan 24, 2023
Merged

MAINT: Fix CIs for sphinx 6 #448

merged 1 commit into from
Jan 24, 2023

Conversation

larsoner
Copy link
Collaborator

Let's see if this fixes CIs -- pin to < 6 when running make html

Also sneaks in a concurrency group to save CI resources in case people push repeatedly / quickly

@larsoner
Copy link
Collaborator Author

@rossbar feel free to merge if you're happy with this workaround

Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @larsoner I agree let's get this in to fix CI

@rossbar rossbar merged commit 11bab2e into numpy:main Jan 24, 2023
@larsoner larsoner deleted the cis branch January 24, 2023 22:30
@jarrodmillman jarrodmillman added this to the 1.6.0 milestone Feb 1, 2023
guillaumedavidphd added a commit to guillaumedavidphd/numpydoc that referenced this pull request Apr 7, 2023
* MAINT: Fix CIs for sphinx 6 (numpy#448)

* BUG: PR06 logic to only fail when type is used standalone (numpy#447)

Change PR06 logic to only fail when type is used standalone.

This prevents failures for user-defined classes, e.g. Mystring

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>

* Update pre-commit (numpy#449)

* Update pre-commit

* Run pre-commit on all files

* Update blacken-docs repo in pre-commit conf after owner transfer. (numpy#451)

* MAINT: Compatibility with pydata-sphinx-theme (numpy#453)

Fix compatibility issues between latest pydata-sphinx-theme and sphinx 6.

Increase granularity of CI to test across necessary sphinx & Python version combos.

* MAINT: Refactoring `get_doc_object` (numpy#452)

---------

Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
Co-authored-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Co-authored-by: yuki <126044367+F3eQnxN3RriK@users.noreply.github.com>
guillaumedavidphd added a commit to guillaumedavidphd/numpydoc that referenced this pull request Apr 18, 2023
* MAINT: Fix CIs for sphinx 6 (numpy#448)

* BUG: PR06 logic to only fail when type is used standalone (numpy#447)

Change PR06 logic to only fail when type is used standalone.

This prevents failures for user-defined classes, e.g. Mystring

Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>

* Update pre-commit (numpy#449)

* Update pre-commit

* Run pre-commit on all files

* Update blacken-docs repo in pre-commit conf after owner transfer. (numpy#451)

* MAINT: Compatibility with pydata-sphinx-theme (numpy#453)

Fix compatibility issues between latest pydata-sphinx-theme and sphinx 6.

Increase granularity of CI to test across necessary sphinx & Python version combos.

* MAINT: Refactoring `get_doc_object` (numpy#452)

---------

Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Bryce Mecum <petridish@gmail.com>
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
Co-authored-by: Jarrod Millman <jarrod.millman@gmail.com>
Co-authored-by: Stefanie Molin <24376333+stefmolin@users.noreply.github.com>
Co-authored-by: yuki <126044367+F3eQnxN3RriK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants