-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the tagindex issue #217
Conversation
Iamanujosh
commented
Mar 1, 2025
•
edited
Loading
edited
- Issue: Issue on page /_tags/tagsindex.html #210
- Fixed an issue where the logo was not switching properly in the "_tags" folder.
- Added logic to detect if the page is inside the "_tags" directory and adjust logo paths accordingly.
- Ensured that the logo updates correctly in both light and dark themes.
@aterrel Could you review this PR when you get a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor update and ready to go. Thanks for the patch
Hey @Iamanujosh, I have a small suggestion to make the code a bit cleaner while keeping the same functionality. Instead of handling _tags/ conditions separately, you can use this approach: |
Hey @aterrel , I wanted to check if you have any remarks on my contribution before we proceed further. If there are no concerns from your side, I’d love to refine it based on the suggestions given. However, if everything looks good, we can close the PR. Let me know your thoughts so we can move forward accordingly. CC: @AR21SM – Thanks for your input! I’m open to improvements, but I’d like to finalize the admin’s feedback first before making further changes. |
Looks a lot cleaner thanks @lamanujosh and @AR21SM I want to play with a local build a bit and then can check it in. Been traveling so haven't had time to do it this past week. |
@all-contributors please add lamanujosh for code |
Could not find the user |
@all-contributors please add Iamanujosh for code |
I've put up a pull request to add @Iamanujosh! 🎉 |
Thank you @aterrel ♥ |