✨(frontend) add tabs for mail domain page #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanchoutNathan
force-pushed
the
feature/add-tabs-mail-domain-view
branch
7 times, most recently
from
ca3c143
to
f853083
Compare
AntoLC
reviewed
Oct 23, 2024
src/frontend/apps/desk/src/features/mail-domains/view/components/MailDomainView.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/desk/src/features/mail-domains/view/components/MailDomainView.tsx
Outdated
Show resolved
Hide resolved
...rontend/apps/desk/src/features/mail-domains/access-management/components/AccessesContent.tsx
Show resolved
Hide resolved
src/frontend/apps/desk/src/features/mail-domains/mailboxes/components/MailDomainsContent.tsx
Show resolved
Hide resolved
src/frontend/apps/e2e/__tests__/app-desk/mail-domain-view.spec.ts
Outdated
Show resolved
Hide resolved
PanchoutNathan
force-pushed
the
feature/add-tabs-mail-domain-view
branch
4 times, most recently
from
a5534a5
to
40a42a6
Compare
AntoLC
reviewed
Oct 23, 2024
AntoLC
approved these changes
Oct 23, 2024
Currently, it is complicated to understand the navigation between mailbox management and role management for an email domain. This is why we add tabs with explicit naming
PanchoutNathan
force-pushed
the
feature/add-tabs-mail-domain-view
branch
from
40a42a6
to
cc81368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently, it is complicated to understand the navigation between mailbox management and role management for an email domain. This is why we add tabs with explicit naming