Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed BacktrackingTM serialization error #3765

Merged
merged 1 commit into from
Aug 21, 2017

Conversation

rhyolight
Copy link
Member

Fixes #3763

@numenta-ci
Copy link
Contributor

@rhyolight, thanks for your PR! By analyzing the history of the files in this pull request, we identified @scottpurdy, @marionleborgne and @subutai to be potential reviewers.

@rhyolight rhyolight requested a review from lscheinkman August 21, 2017 19:17
@rhyolight
Copy link
Member Author

@lscheinkman

@lscheinkman
Copy link
Contributor

lscheinkman commented Aug 21, 2017

@rhyolight This class serialization is currently not covered by our tests (see https://ci.numenta.com/browse/NUP-PY-561/artifact/TL/HTML-Coverage-Report/_root_bamboo-agent-home_xml-data_build-dir_NUP-PY-TL_src_nupic_algorithms_backtracking_tm.html#n1372). That's why it remained unnoticed. Maybe we could also add a test covering this issue, either in this PR or in a separate PR.

@rhyolight
Copy link
Member Author

@lscheinkman I'd be more than happy if someone did this, but honestly increasing test coverage on this code base is not a high priority. If anyone reading this wants to create an issue and a test to cover this bug, please do.

@rhyolight rhyolight merged commit 066e183 into numenta:master Aug 21, 2017
@rhyolight rhyolight deleted the fix-btm-serialization branch August 21, 2017 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants