Remove all user data on logging out. #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanwu1105
changed the base branch from
develop
to
release-remove-data-on-logout
shc261392
requested changes
Feb 18, 2021
| @@ -231,6 +232,12 @@ export class ImageStore { | |||
| }); | |||
| }); | |||
| } | |||
|
|
|||
| async drop() { | |||
There was a problem hiding this comment.
It seems the drop() function isn't used anywhere except for tests, and same for the capacitor filesystem table drop implementation. If it's not used then it should be removed.
There was a problem hiding this comment.
The drop method helps the tests to clean up the persistence storage without exposing the internal implementation. Thus, IMHO, the method still need to exist.
There was a problem hiding this comment.
Looks like it's a good reason and is the cleanest way to do it so I'm fine with that.
shc261392
approved these changes
Feb 18, 2021
| @@ -231,6 +232,12 @@ export class ImageStore { | |||
| }); | |||
| }); | |||
| } | |||
|
|
|||
| async drop() { | |||
There was a problem hiding this comment.
Looks like it's a good reason and is the cleanest way to do it so I'm fine with that.
seanwu1105
changed the base branch from
release-remove-data-on-logout
to
develop
This was referenced Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #369. This PR has several changes regarding data persistence.
clearmethod onDatabase.clearmethod onTableinterface.clearmethod onPreferenceManager.clearmethod onPreferencesinterface.undefinedafter beingcleared.Observablewill NOT emit new value after beingcleared (withisNonNullableoperator).Promisewill emit the default value after beingcleared.Preferencesimplementations.clearmethod onImageStore.DiaBackendAuthService.logout$()ImageStore,DatabaseandPreferenceManager.This PR has been tested on Brave browser and Exodus 1.