Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature try 2 play go pro videos with native players #1520

Merged
merged 11 commits into from
Apr 11, 2022
Merged

Feature try 2 play go pro videos with native players #1520

merged 11 commits into from
Apr 11, 2022

Conversation

sultanmyrza
Copy link
Contributor

@sultanmyrza sultanmyrza commented Apr 8, 2022

┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang

@@ -43,9 +43,27 @@ export class GoProMediaItemDetailOnCameraComponent implements OnInit {
}

ngOnInit() {
// TODO: git reset this function
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I don't understand what does it mean for TODO: git reset this function

Copy link
Contributor

@shc261392 shc261392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@shc261392 shc261392 merged commit 11c83e6 into numbersprotocol:develop Apr 11, 2022
@sultanmyrza sultanmyrza deleted the feature-try-2-play-go-pro-videos-with-native-players branch April 11, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants