feat: Add sequences defined by a formula in n to the main tool #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by creating and exporting a SequenceFormula class. In addition, adding this class seemed to spark an additional cascade of the Vue components needing to be (more) strongly typed. So the commit has numerous new type annotations (that should have no effect other than to aid TypeScript type checking) and a slight modification/simplification to the interface between sequences.ts and visualizers.ts on the one hand and ToolMain.vue on the other, since I could not figure out out to type the old interface (and a lot of extraneous information that was never being used was being passed anyway). Hopefully these changes will eliminate issue numberscope#28. Also, again as part of shoring up the typing, finally eliminates the spurious additional copy of the p5 code in src/assets, instead relying on npm install to get the proper copy of p5 in the right place. (The point being that the idiosyncratic copy was not typed, but npm brings in the type definitions automatically if you rely on it.) Resolves numberscope#14.
liammulh
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by creating and exporting a SequenceFormula class.
In addition, adding this class seemed to spark an additional cascade
of the Vue components needing to be (more) strongly typed. So the commit
has numerous new type annotations (that should have no effect other than
to aid TypeScript type checking) and a slight modification/simplification
to the interface between sequences.ts and visualizers.ts on the one hand
and ToolMain.vue on the other, since I could not figure out out to type
the old interface (and a lot of extraneous information that was never
being used was being passed anyway). Hopefully these changes will
eliminate issue #28.
Also, again as part of shoring up the typing, finally eliminates the
spurious additional copy of the p5 code in src/assets, instead relying
on npm install to get the proper copy of p5 in the right place. (The point
being that the idiosyncratic copy was not typed, but npm brings in the
type definitions automatically if you rely on it.)
Resolves #14.