Testing sprout 🌱 #84
Merged
Testing sprout 🌱 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs server to be running already.
Use test client instead of already-running server.
By choosing a sequence with fewer references and smaller values
Get revisions to documentation and views.py
Also, only show mid-test messages in verbose mode
This is really convoluted. We should find a better way to handle it.
To clarify a reference to the PostgreSQL installation docs, I changed what looked like a sectioning error.
katestange
requested changes
Oct 20, 2023
gwhitney
reviewed
Oct 20, 2023
gwhitney
reviewed
Oct 20, 2023
|
OK, I made a couple of small comments/suggestions, but overall this looks really good! So once Kate's resolved her items and Aaron's had a chance to respond to the things I raised, this should be ready to merge. Thanks, Aaron! |
added 2 commits
October 20, 2023 20:26
Continuous integration will be in a different pull request.
|
OK, as far as I can see, everything is set here for merging. But as Kate has to sign off as the original reviewer, I can't merge on the spot. Kate, when you have a chance, make sure you feel all is well, sign off, and merge. Thanks! |
katestange
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request develops @liammulh's prototype test (
TrivialTest) into a small suite of useful tests.Notable features
doc/tests.md).AbstractEndpointTest).Pitfalls
POSTGRES_DISPOSABLE_DBis unset or empty, but the code that makes this happen is very convoluted. It ought to be simplified at some point.ProdConfigto accommodate other changes, but I don't know how to make sure production mode still works.To do
See
# TO DOcomments.AbstractEndpointTestto test the background work triggered by each endpoint request.