fix: Determine git revision hash once at startup #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, the server continues to supply the correct git revision hash even if the code changes after startup. Unless overridden by an environment variable, simply uses `git rev-parse --short HEAD`. In production, uses the environment override because the eventual flask process doesn't have the correct permissions to perform the git command. Resolves numberscope#108.
katestange
approved these changes
Apr 9, 2024
gwhitney
added a commit
to gwhitney/backscope
that referenced
this pull request
Apr 10, 2024
katestange
pushed a commit
that referenced
this pull request
Apr 10, 2024
Vectornaut
pushed a commit
to Vectornaut/backscope
that referenced
this pull request
Apr 10, 2024
Merge in commit hash endpoint (pull requests numberscope#113 and numberscope#114). Also, add some requirements that seemed to be missing. Not sure how that happened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the server continues to supply the correct git revision hash
even if the code changes after startup. Unless overridden by an
environment variable, simply uses
git rev-parse --short HEAD. Inproduction, uses the environment override because the eventual flask
process doesn't have the correct permissions to perform the git
command.
Resolves #108.