Fix refct pruning not removing refct op with tail call. #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test to check refct pruning behavior
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #2349 +/- ##
==========================================
+ Coverage 86.66% 86.66% +<.01%
==========================================
Files 317 317
Lines 58412 58437 +25
Branches 6027 6032 +5
==========================================
+ Hits 50620 50645 +25
Misses 6830 6830
Partials 962 962 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, add test to check refct pruning behavior.
(Followup to #2346)
More notes:
I slightly refactored the
remove_redundant_nrt_refctso that it is easier to test with a string input.