Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): replicas calculation for paused pipeline #2412

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Feb 20, 2025

Explain what this PR does.

Signed-off-by: Derek Wang <whynowy@gmail.com>
@whynowy whynowy requested a review from vigith as a code owner February 20, 2025 18:10
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 71.15%. Comparing base (ae6c2a6) to head (3c0fb9d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/reconciler/pipeline/controller.go 25.00% 5 Missing and 1 partial ⚠️
pkg/reconciler/vertex/controller.go 14.28% 4 Missing and 2 partials ⚠️
pkg/reconciler/vertex/scaling/scaling.go 0.00% 5 Missing ⚠️
pkg/reconciler/monovertex/scaling/scaling.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2412      +/-   ##
==========================================
+ Coverage   71.03%   71.15%   +0.11%     
==========================================
  Files         368      368              
  Lines       53558    53575      +17     
==========================================
+ Hits        38047    38123      +76     
+ Misses      14435    14373      -62     
- Partials     1076     1079       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.
Signed-off-by: Derek Wang <whynowy@gmail.com>
@whynowy whynowy enabled auto-merge (squash) February 20, 2025 20:01
@whynowy whynowy merged commit ef0cffd into numaproj:main Feb 20, 2025
25 checks passed
whynowy added a commit that referenced this pull request Feb 20, 2025
Signed-off-by: Derek Wang <whynowy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants