chore: display error mssg based on api error response for metric charts #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2298 +/- ##
==========================================
- Coverage 67.67% 67.61% -0.06%
==========================================
Files 351 351
Lines 45918 45918
==========================================
- Hits 31074 31047 -27
- Misses 13768 13793 +25
- Partials 1076 1078 +2 ☔ View full report in Codecov by Sentry. |
|
@whynowy: does this PR makes sense? Only thing is error response from prom client may not be a proper formatted text. Otherwise, in my view, it gives more context about the error. |
|
Shall we use the error on the right to display error message? 
|
sure |
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
|
veds-g
reviewed
Jan 15, 2025
...ls/NodeInfo/partials/Pods/partials/PodDetails/partials/Metrics/partials/EmptyChart/index.tsx
Outdated
Show resolved
Hide resolved
veds-g
reviewed
Jan 15, 2025
...als/NodeInfo/partials/Pods/partials/PodDetails/partials/Metrics/partials/LineChart/index.tsx
Outdated
Show resolved
Hide resolved
veds-g
reviewed
Jan 15, 2025
...als/NodeInfo/partials/Pods/partials/PodDetails/partials/Metrics/partials/LineChart/index.tsx
Outdated
Show resolved
Hide resolved
veds-g
reviewed
Jan 15, 2025
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
veds-g
approved these changes
Jan 17, 2025
vigith
approved these changes
Jan 17, 2025
SaniyaKalamkar
pushed a commit
to SaniyaKalamkar/numaflow
that referenced
this pull request
Jan 19, 2025
…ts (numaproj#2298) Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
veds-g
pushed a commit
that referenced
this pull request
Feb 19, 2025
…ts (#2298) Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If metrics API gives error response, push the error mssg to error indicator tooltip, otherwise (when err is null), display default message.
Currently we are displaying default message in all the cases. This PR change would add context for the user.