-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make unit and display name configurable #2269
Merged
adarsh0728
merged 8 commits into
numaproj:main
from
adarsh0728:feat/add-legends-to-charts
Jan 8, 2025
Merged
feat: make unit and display name configurable #2269
adarsh0728
merged 8 commits into
numaproj:main
from
adarsh0728:feat/add-legends-to-charts
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2269 +/- ##
==========================================
+ Coverage 67.08% 67.28% +0.19%
==========================================
Files 349 351 +2
Lines 45055 45275 +220
==========================================
+ Hits 30227 30463 +236
+ Misses 13756 13743 -13
+ Partials 1072 1069 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
vigith
approved these changes
Jan 6, 2025
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Resolved comment. Below are the screenshots after the latest changes. ![]() ![]() |
SaniyaKalamkar
pushed a commit
to SaniyaKalamkar/numaflow
that referenced
this pull request
Jan 19, 2025
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
veds-g
pushed a commit
that referenced
this pull request
Feb 19, 2025
Signed-off-by: adarsh0728 <gooneriitk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2268
Resolves #2279